Handlebars-Net / Handlebars.Net

A real .NET Handlebars engine
MIT License
1.22k stars 213 forks source link

Add EmbedUntrackedSources #570

Closed lahma closed 3 months ago

lahma commented 5 months ago

I would also suggest changing to use newer GH Actions images for building so that other warnings would go away (old SDK in use). Maybe another modernization step could be removing old unsupported full framework targets and only support oldest supported net462. Adding net6.0 target would allow one target without dependency on Microsoft.Csharp.

StefH commented 5 months ago

@lahma Thank you. But actually the "license expression" is already fixed by me (https://github.com/Handlebars-Net/Handlebars.Net/pull/564)

About EmbedUntrackedSources --> that's ok.

And thanks about the hint for "newer GH Actions images", I'll take a look.

lahma commented 5 months ago

Ah, great minds think a like I guess 😄 I've updated the PR title and contents to only contain EmbedUntrackedSources set to true

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud