search

Handlebars-Net / Handlebars.Net

A real .NET Handlebars engine
MIT License
1.22k stars 213 forks source link

Update of TFM & dependency optimisation #578

Closed thompson-tomo closed 3 months ago

thompson-tomo commented 3 months ago

By adjusting the TFM'S we have been able to produce a package with no dependencies on the latest frameworks hence an optimised dependency graph.

The following frameworks have been added:

The following frameworks even though requested was not added:

The following frameworks were removed:

Closes: #573 Closes: #415

thompson-tomo commented 3 months ago

I don't see a benefit in adding dotnet 8 as the dotnet 6 compilation will be used. Will remove net 5.

Thoughts on also dropping net 452, net 46 as it is the same as the net 451 compilation.

oformaniuk commented 3 months ago

Thoughts on also dropping net 452, net 46 as it is the same as the net 451 compilation.

Yes, this is a good idea to optimize monikers 👍

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

thompson-tomo commented 3 months ago

@oformaniuk i have just gone & dropped those 2 TFM's from the package.

oformaniuk commented 3 months ago

@thompson-tomo , CI pipeline is now broken: https://github.com/Handlebars-Net/Handlebars.Net/actions/runs/8524444266/job/23349047350

thompson-tomo commented 3 months ago

@oformaniuk should be Fixed in #579