'Required fields' are not actually required.

HandmadeWeb / buildamic

Buildamic is a Pagebuilder addon for Statamic 3

MIT License

12 stars 2 forks source link

'Required fields' are not actually required. #20

Open jelleroorda opened 3 years ago

jelleroorda commented 3 years ago

Bug Description

'Required’ fields are not required when editing in the Buildamic editor. I.e. when editing sets and fields.

How to Reproduce

Add some fields and make them required in the blueprint. Now try to add a field, and then close the drawer and save.

https://user-images.githubusercontent.com/9193686/132004344-f3a269f7-e758-4bfc-bfe4-71981c7a640c.mov

Environment

Statamic 3.2.2 Pro Laravel 8.58.0 PHP 8.0.6 edalzell/blade-directives 3.5 handmadeweb/buildamic dev-main

michaelr0 commented 3 years ago

Thanks Jelle,

I had started to look into this and conditional fields, both looked like they were going to be tricky, so had been put on the back burner.

Rules will probably be the first of the two that I'll revist, no ETA yet tho.

sliver37 commented 2 years ago

I've implemented field conditions, and I'll make the required fields work alongside the new saving method (when hitting the save button, it will check those conditions).