search

HandmadeWeb / buildamic

Buildamic is a Pagebuilder addon for Statamic 3
MIT License
12 stars 2 forks source link

Hitting escape in a drawer saves the drawer, instead of canceling edits. #21

Open jelleroorda opened 3 years ago

jelleroorda commented 3 years ago

Bug Description

Hitting the escape key to close the drawer will still persist data inside the drawer. Since it works with the vue store, I am not sure if this is just ‘how it works’, or whether it would be possible to implement. I think it's possible since this is similar how editing blueprints works in Statamic (canceling, escape or clicking outside is the same):

https://user-images.githubusercontent.com/9193686/132004753-30f980c0-6022-4c50-86b9-7a7d0a0a30ae.mov

How to Reproduce

Edit something and see that it actually updated the values, instead of canceling them.

Extra Detail

https://user-images.githubusercontent.com/9193686/132004706-4db55e06-2907-4692-979c-a946df806e71.mov

Environment

Statamic 3.2.2 Pro Laravel 8.58.0 PHP 8.0.6 edalzell/blade-directives 3.5 handmadeweb/buildamic dev-main

michaelr0 commented 2 years ago

@sliver37 this was resolved recently wasn't it?