Right now, some of the cypress tests regarding snackbar content have visibility checks attached to them, and some don't. The visibility checks were added to fix timing issues when they arose. We are still unclear about whether it would be good to add visibility checks to all of them as a preventative check, or whether adding the visibility checks is unnecessary clutter.
Additionally, we currently have all snackbar durations set to a hard coded 5000ms, which leads to some cy.wait() statements with an arbitrary seeming 5100ms (waiting for the snackbar to dissapear somewhere). Ideally, this value for snackbar duration should be moved to a project-wide constant somewhere. For the cypress tests, we should probably change from waiting for the snackbar to disappear independently, we should instead use the 'OK' confirmation within the snackbar to close the snackbar more quickly.
Right now, some of the cypress tests regarding snackbar content have visibility checks attached to them, and some don't. The visibility checks were added to fix timing issues when they arose. We are still unclear about whether it would be good to add visibility checks to all of them as a preventative check, or whether adding the visibility checks is unnecessary clutter.
Additionally, we currently have all snackbar durations set to a hard coded 5000ms, which leads to some cy.wait() statements with an arbitrary seeming 5100ms (waiting for the snackbar to dissapear somewhere). Ideally, this value for snackbar duration should be moved to a project-wide constant somewhere. For the cypress tests, we should probably change from waiting for the snackbar to disappear independently, we should instead use the 'OK' confirmation within the snackbar to close the snackbar more quickly.