Load pantry with aggregation - Githubissues

HandyPantry / handy-pantry

MIT License

0 stars 1 forks source link

Load pantry with aggregation #43

Open jpwalbran opened 2 years ago

jpwalbran commented 2 years ago

Implement an aggregation query to return the pantry items grouped by their category, and display the category counts similar to the changes to the product display detailed in PR GH-20.

lgtm-com[bot] commented 2 years ago

This pull request introduces 4 alerts when merging e2aa10f1448f3540a26ad7b5836016f0242b5f26 into 4a9651f75609499e7f83f051e2925b5928c720e4 - view on LGTM.com

new alerts:

4 for Unused variable, import, function or class

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging df45a25637af550479cb050cb0582278388c5ad8 into 4a9651f75609499e7f83f051e2925b5928c720e4 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging a03eb7dd0ebebbf65ab1742f49cff1c65bc88c5a into 4a9651f75609499e7f83f051e2925b5928c720e4 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging b6870e13ebc3ec0b731a19b4964f14c5946872f7 into 4a9651f75609499e7f83f051e2925b5928c720e4 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging 822278ab7ab93b526daa5dea0f985ac652987bfe into 4a9651f75609499e7f83f051e2925b5928c720e4 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging a8cb03f316d451f704ffbdb28f264b14f1af7a21 into 4a9651f75609499e7f83f051e2925b5928c720e4 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

jpwalbran commented 2 years ago

Closes #2

NicMcPhee commented 2 years ago

Also, if you look at the "Write Code Once" part of the BCH report, we've got quite a lot of duplicate code creeping in, with a lot of it coming from the recent extensions that you've made. You could try to address some of that in this PR, or you could merge this in, and do some refactoring in a subsequent PR.