search

Handyfon / Farchievements

Foundry Achievments. The first module to add player achievements to FoundryVTT!
3 stars 5 forks source link

Player gets error #6

Closed Ikabodo closed 3 years ago

Ikabodo commented 3 years ago

image One of my player's is getting this strange error. He cannot see any achievements.

I tried logging in to the player's account and I can se them, but he cannot. Tried on two different computers.

I'll try to find more info, but for now it's kinda puzzling.

Chrome

xlilcasper commented 3 years ago

Sent this on discord but posting it here just in case.

basically it has to do with the fact that the setting clientdata can be empty in a new world. I added a line to AchievementsScreen.js at line 308 if(mysettings == "") mysettings = ":"

This allowed syncing to happen if mysettings was empty. I also changed line 73 of AchievementsScreen.html (not sure if needed). Changed it to

if(game.settings.get('farchievements', 'clientdata').toString().length > 0 && ( game.settings.get('farchievements', 'clientdata').toString().split(":")[1].includes("," + i + ",") || game.settings.get('farc...

that way if clientdata is 0 length, it heads to the else and displays it properly

Ikabodo commented 3 years ago

Cool, thanks for the reply. Didn't get anything in discord though. :)

I assume this will be in an update by the way? I'll try it with the player when I get the chance.

Handyfon commented 3 years ago

Should be fixed