Handyfon / roll-of-fate

Roll of fate for FoundryVTT, for GM's who don't want to be blamed.
GNU General Public License v3.0
5 stars 5 forks source link

Problems with color text (Conflict with Chat Portrait module) #15

Closed Fridan99 closed 2 years ago

Fridan99 commented 2 years ago

Describe the bug Apparently there is an interaction between the roll of fate and the chat portrait. When used together, the roll of fate letters cannot change color.

I am not sure which module creates the actual conflict, chat portrait or roll of fate.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'install Roll of Fate and Chat Portrait modules'

Expected behavior No conflict with modules.

Screenshots text

Browser: NO. App itself

Foundry 0.9.249 System dnd5e 1.5.7 Roll of Fate 0.4.6 Chat Portrait 0.6.0

p4535992 commented 2 years ago

@Handyfon For fix this the right way on my side i need you to add some customize class on the html of the chat message like roll-of-fate the most simple example:

<div class="roll-of-fate" style="background: ${sBackgroundColor};

Handyfon commented 2 years ago

Unfortunatly it isn't as simple as a fix, as "Chat Potrait" just inserts its custom classes into the roll of fate cards, even when all references to base foundry classes are removed. I included a fix that overwrites the color and center but it's not as customizable except for custom css.

p4535992 commented 2 years ago

hello sorry maybe I expressed myself wrong what I mean is that for my use case I need any html element that allows me to identify the message as coming from your module (at the level of pure html content I mean). It could also be an attribute like data-roll-of-fate=true .