Handyfon / roll-of-fate

Roll of fate for FoundryVTT, for GM's who don't want to be blamed.
GNU General Public License v3.0
5 stars 5 forks source link

Any plans to compatibility v12? #26

Closed Fridan99 closed 2 weeks ago

Fridan99 commented 3 months ago

are there any plans to migrate to v12? or a fork somewhere? Thank you.

Fridan99 commented 3 months ago

For the moment, I have created a macro that does the function of the module, until the module is updated, or in case it does not receive an update, it can do the same function.

https://github.com/Fridan99/Macros/blob/main/5e-macros/utility/v11/Beshaba%20and%20Tymora's%20Fate

kiloforce commented 1 month ago

image

                let tokens = canvas.tokens.controlled;
                ...

                for(let i = 0; i < tokens.length ; i++) {
                        if(i != (tokens.length -1)){
                        selectedstring = selectedstring + "<label class='ROFtokenname'>" + tokens[i].data.name +",</label>";
                        }
                        else{
                        selectedstring = selectedstring + "<label class='ROFtokenname'>" + tokens[i].data.name +"</label>";
                        }
                }
kiloforce commented 1 month ago

Looks like the .data level was removed and name was pulled up a level. Seems like "tokens[i].data.name" could just be changed to "tokens[i].name"?

kiloforce commented 1 month ago

Until the pull request is pulled into the official repo, have a proof of concept release here: https://github.com/kiloforce/foundry-roll-of-fate/releases/download/12.0.0/module.json