Haneke / HanekeSwift

A lightweight generic cache for iOS written in Swift with extra love for images.
Apache License 2.0
5.2k stars 591 forks source link

Swift 4.0 support added #421

Closed lanserxt closed 6 years ago

dcharbonnier commented 6 years ago

thx, can you fix the the travis configuration or the tests please ?

lanserxt commented 6 years ago

Hello,

Looks like need to add

xcode_sdk: iphonesimulator10.0

Where can I change the .yml?

dcharbonnier commented 6 years ago

You can add it to this PR or do an other PR

gringoireDM commented 6 years ago

On the swift 4 you might want to update travis config to use xCode 9.

lanserxt commented 6 years ago

Will update tests also

dcharbonnier commented 6 years ago

great, thanks @lanserxt !

lanserxt commented 6 years ago

@dcharbonnier all done, safe to merge

lanserxt commented 6 years ago

@gringoireDM What version should I set? Currently set 1.1 for Xcode and 0.10.2 for pod spec. Swift version file added.

dcharbonnier commented 6 years ago

No one has access to the pod account. If you want to release it you will have to change the name

gringoireDM commented 6 years ago

@dcharbonnier please do. Haneke_Swift maybe? To release new pod version is important if you want still maintain the project.

dcharbonnier commented 6 years ago

Thx !! For the pod, I don't even have a Mac anymore ;-)

gringoireDM commented 6 years ago

Just admit that the library is discontinued. Anyway we moved away from it. Thank you anyway.

lanserxt commented 6 years ago

@dcharbonnier You are welcome!

dcharbonnier commented 6 years ago

With people like @lanserxt I think we can say it's alive and the more people will contribute the more this project will be alive. If there is a better project, with more contributors or a project you like more, people can move away and are welcome back when they want :-) It's like cocoapod vs carthage. Now if someone want to take the responsibility of deploying and maintaining a pod, he is free to do it and will get my support, this project is open.

gringoireDM commented 6 years ago

You don't even have a Mac to test the code you are going to approve. How can you say this is a maintained project?

I do understand the importance of contributions, but a pod cannot stand just on contributions. It's important that the maintainer helps as well at least with the most basic things like tagging releases, testing before merging a PR, releasing new pod versions. There are things that contributors cannot do. If you don't whish to do them either, handover the ownership of the repository or declare it unmaintained. In any case, like I said before, we already removed haneke as dependency since you are willing to approve anything that pass the travis build.

We are off topic.

smhk commented 6 years ago

Hoy caramba !

Cocoapods is horrible. Carthage is the only way to go.

one vote!

(Soon, Swift Package Manager will be here and cocoapods will finally be dead.)

dcharbonnier commented 6 years ago

Join the chat at https://gitter.im/Haneke/HanekeSwift