saving project settings with validation errors on one tab fails when saving another tab - Githubissues

HangarMC / Hangar

A plugin repository used for paper plugins

https://hangar.papermc.io/

MIT License

253 stars 64 forks source link

saving project settings with validation errors on one tab fails when saving another tab #1168

Open Pheotis opened 1 year ago

Pheotis commented 1 year ago

Observed/problematic behavior

When adding link sections to a project, attempting to enter any combination of values invariably fails with one of several errors.

Expected behavior

It should be possible to add link sections to project pages.

Steps to reproduce

Go to User/Project/settings/links
Add a top link
type any text and a URL:
click "Save Changes"
Observe an error (most often this one):
Reload / refresh page.
Add a sidebar
Add any text and a url:
click "Save Changes"
Observe either:
- OR, no error at all; it looks like it works, but when you go to your page, there is no sidebar there.
- Returning to the links page shows that there was never a sidebar created.

Other

Firefox 112.0.1 on Windows 10, tested on a project made under an organization. Hangar commit fe37740

Pheotis commented 1 year ago

It would oddly appear that this only impacts our project's page. If I create a new project, either under an org or under my profile, I can edit links just fine.

This possibly might have something to do with the fact that our page had