search

HangarMC / Hangar

A plugin repository used for paper plugins
https://hangar.papermc.io/
MIT License
249 stars 65 forks source link

Extract PinnedStatus enum from VersionCompact to prevent invalid openapi paths #1379

Closed JulianVennen closed 1 month ago

JulianVennen commented 1 month ago

The current API spec has a schema with the name "io.papermc.hangar.model.api.project.version.VersionCompact$PinnedStatus". This is not allowed in the OpenAPI spec and causes the Swagger Editor and OpenAPI Generator to throw errors.

This PR extracts this inner class to its own file to prevent this issue.

JulianVennen commented 1 month ago

I'm also not entirely sure if it's intended that the schema names are now the full package name (io.papermc.hangar.model.api...) or since when that's the case.

MiniDigger commented 1 month ago

fixed the fully qualified names, I assume this isnt needed then? thanks anyways