HangarMC / Hangar

A plugin repository used for paper plugins
https://hangar.papermc.io/
MIT License
249 stars 65 forks source link

Profile website url automatically appends https:// without the user knowing #1382

Closed FlorianMichael closed 1 month ago

FlorianMichael commented 1 month ago

Observed/problematic behavior

Putting your website url in your Hangar profile settings like this:

image

will end up in https://https//florianmichael.de because Hangar automatically puts https:// at the url start.

Expected behavior

Detect if the user inputs a website url starting with https:// and cut it off so the url doesn't end up being wrong.

Steps to reproduce

  1. Open https://hangar.papermc.io/auth/settings/profile or go to your profile settings manually.
  2. Add a link with type Website
  3. Use https://florianmichael.de or any other url starting with https://
  4. Save

Other

I also just realized that kenny made the same assumption as me: https://hangar.papermc.io/kennytv

No response

MiniDigger commented 1 month ago

duplicate of #1370, prod was just deployed with the fix