HangfireIO / Cronos

A fully-featured .NET library for working with Cron expressions. Built with time zones in mind and intuitively handles daylight saving time transitions
MIT License
1.01k stars 120 forks source link

The documentation for GetOccurences is wrong. #28

Closed nickduch closed 3 years ago

nickduch commented 4 years ago

In the README, at this paragraph: https://github.com/HangfireIO/Cronos/blob/master/README.md#getting-occurrences-within-a-range.

The return type should be IEnumerable<DateTime> instead of DateTime?. IEnumerable<DateTime> occurrences = expression.GetOccurrences( DateTime.UtcNow, DateTime.UtcNow.AddYears(1), fromInclusive: true, toInclusive: false);

odinserj commented 3 years ago

Thanks, was already fixed!