search

HangfireIO / Cronos

A fully-featured .NET library for working with Cron expressions. Built with time zones in mind and intuitively handles daylight saving time transitions
MIT License
974 stars 114 forks source link

Missing step in '?' grammar #57

Closed Pandetthe closed 1 year ago

odinserj commented 1 year ago

Please share an example expression that isn't covered by the grammar.

Pandetthe commented 1 year ago

?/2

Pandetthe commented 1 year ago

In readme '?' is described as "? is synonym of *", but in the grammar '?' don't allow step, that is working in CronExpression.Parse

Pandetthe commented 1 year ago

And there is a second problem with grammar, that step isn't in brackets [], so '*' is invalid but '*/2' is valid.

odinserj commented 1 year ago

You are totally correct, we also need to wrap it with [] in both cases.

odinserj commented 1 year ago

Thanks a lot @Pandetthe! I've also moved them closer to the * character.