search

HangfireIO / Cronos

A fully-featured .NET library for working with Cron expressions. Built with time zones in mind and intuitively handles daylight saving time transitions
MIT License
974 stars 114 forks source link

Feature Request: "TryParse" or/and "IsValid" methods #59

Closed Pirand92 closed 6 months ago

Pirand92 commented 11 months ago

Hi everyone,

could be possible to have one of these two methods to avoid everytime to catch the CronFormatException? If you allow users to contribute on the project, I'll be enthusiast to create a PR on that.

Thanks for attention.

odinserj commented 11 months ago

Yeah, sure, will be happy to get this awesome PR!

Pirand92 commented 10 months ago

Yeah, sure, will be happy to get this awesome PR!

Thanks. Finally I found time to work on this. Unfortunately I'm facing with an issue when I try to push my branch (error 403) on this repository, could be you have set some security policy to prevent that?

Thanks for support.

FaithfulDev commented 7 months ago

@Pirand92 If I understand correctly, you made a branch, committed stuff on it and now try to push that branch to this specific repository? If so, you can't do that.

You need to fork this repository (here is the fork link for this repo), this will create a "copy" of this repository in your personal namespace. There, you make any commits you need. Once you are done, create a new PR, specifying your fork branch as the source.

This is the usual way you contribute to GitHub projects. Hope that helps.

Pirand92 commented 7 months ago

@FaithfulDev thanks a lot for your explanation. I'm used to work on Azure DevOps and there the procedure is slightly different