search

HangfireIO / Hangfire

An easy way to perform background job processing in .NET and .NET Core applications. No Windows Service or separate process required
https://www.hangfire.io
Other
9.43k stars 1.7k forks source link

Feature/disable recurring jobs #2432

Closed Kithuldeniya closed 3 months ago

Kithuldeniya commented 3 months ago

Requested issue : Disable Recurring Job from Dashboard #2289

Initiating a recurrent job

When creating a recurrent job, you can use RecurringJobOptions to disable the job. By default, this value is set to false, ensuring that existing jobs remain unaffected. image

Visual in the dashboard

Disabled jobs can be identified in the dashboard by the ‘Disabled’ tag, which appears with a tooltip under the ‘Next Execution’ column. image

Action popups

The enable and disable actions will trigger a popup to obtain user confirmation. image image

DCarlson12 commented 3 months ago

Duplicate of #2431, pretty much copying my PR not even 24h later with some changed method names...

Kithuldeniya commented 3 months ago

Don’t assume that no one will need to refer to your pull request to come up with method names if you’re following the existing method standards.

DCarlson12 commented 3 months ago

Don’t assume that no one will need to refer to your pull request to come up with method names if you’re following the existing method standards.

It’s not just that, you copied almost my entire implementation, even down to the very glyph for the icons on the buttons. Just a little suspicious…

Kithuldeniya commented 3 months ago

Closing PR as this PR has the similer feature to https://github.com/HangfireIO/Hangfire/pull/2431