search

Hanjun-Dai / pytorch_structure2vec

pytorch implementation of structure2vec (https://arxiv.org/abs/1603.05629)
MIT License
305 stars 76 forks source link

MacOS compilation #4

Closed AntoinePrv closed 6 years ago

AntoinePrv commented 6 years ago

Hello,

The Makefile doesn't work out of the box on MacOS for the simple reason that find doesn't have a printf option.

I replaced this line with

cpp_files = $(shell $(FIND) src/lib -name "*.cpp" -print | rev | cut -d"/" -f1 | rev)

It seems to do the trick under both MacOS and Linux

Hanjun-Dai commented 6 years ago

Nice trick! I've merged it into the repository, thanks!

btw, previously I installed gnu find using homebrew in MaxOS, so I didn't realize this problem.