search

HankG / slimtune

Automatically exported from code.google.com/p/slimtune
MIT License
0 stars 0 forks source link

Data Consistency #38

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
There appears to be some inconsistencies in collected samples data:

For example

SELECT * 
 FROM Samples 
WHERE FunctionID = 2772

gives

ThreadId FunctionId HitCount
    5   2772    230
    4   2772    344

On the other hand

SELECT * 
 FROM Callers
WHERE CallerId = 2772

gives

ThreadId CallerId HitCount CalleeId
    5   2772    1   0
    5   2772    4248    2774
    4   2772    13406   2774
    4   2772    3   3223

The error appears to be in SQLiteEngine.cs in FlushSamples.

Binding for 3rd argument should have been threadKvp.Value.

Original issue reported on code.google.com by kavanpro...@gmail.com on 6 Mar 2010 at 11:54

GoogleCodeExporter commented 9 years ago 
Actually caught this and fixed it in SVN, it should be fine for v0.2.2.

Original comment by promit....@gmail.com on 7 Mar 2010 at 12:29

GoogleCodeExporter commented 9 years ago 
Not sure what you mean by fixing it in SVN, but browse source still shows 
threadKvp.Key.

Original comment by kavanpro...@gmail.com on 7 Mar 2010 at 1:09

GoogleCodeExporter commented 9 years ago 
Oh. Yeah, I guess I haven't checked it in yet. I'll probably check in all the 
various
bug fixes and push out the new release the week after GDC or something.

Original comment by promit....@gmail.com on 7 Mar 2010 at 1:14