search

Hankintailmoitukset / hilma-api

11 stars 0 forks source link

TED rejects contract award notice #110

Closed anttiremes closed 3 years ago

anttiremes commented 3 years ago

Describe the bug TED gives error NOTICE_NUMBER_OJ missing

Notice ets: etsidfixed_63380

To Reproduce https://api.hankintailmoitukset.fi/ets/external-api/v1/notice/etsidfixed_63380?parentId=etsidfixed_32277&projectId=41842

anttiremes commented 3 years ago

Same problem with notice: etsidfixed_63047

arinurkkala commented 3 years ago

Investigating

arinurkkala commented 3 years ago

PreviousNoticeOjsNumber was not provided in the request. Please provide it.

anttiremes commented 3 years ago

In documentation:

previousNoticeOjsNumber string Comment: IV.2.1) Previous publication concerning this procedure If this tender is related to a tender previously published in TED, the TED OJS number of that previous TED must be given. If tender is not related, leave as null. If the previous tender was described by a notice published via new Hilma or Hilma Ets API, parenting the new notice to that notice will take care of filling the previous notice OJS number automatically.

this doesn't work "parenting the new notice to that notice will take care of filling the previous notice OJS number automatically."

arinurkkala commented 3 years ago

We released Hilma v 2.4.0 into production yesterday - could you verify if this bug is still valid?

I tried reproducing the problem, but could not.

anttiremes commented 3 years ago

etsidfixed_63047 gives same error

arinurkkala commented 3 years ago

We have identified that when a notice is updated via ETS api, the previousNoticeOjsNumber is not handled as per the comment. It is done only in create. If you want to publish those notices, you have 2 options:

  1. Provide the previousNoticeOjsNumber in the contract award update.
  2. Create a new contract award with the same data.

We will add the previousNoticeOjsNumber to update action as well in the near future.

arinurkkala commented 3 years ago

Should be fixed now. Can you verify and close, if ok?