search

Hankintailmoitukset / hilma-api

12 stars 0 forks source link

Hilma shows wrong information about national treshold #128

Closed anttiremes closed 2 years ago

anttiremes commented 2 years ago

ATTENTION! Fill in the following information but DO NOT include any non-public information such as API keys or actual notice data.

Describe the bug etsidentifier: production_82952

"EstimatedValue": { "Type": 2, "MinValue": 30000.0, "MaxValue": 45000.0, "Currency": "EUR", "DisagreeToBePublished": false },

https://www.hankintailmoitukset.fi/fi/public/procurement/63164/notice/89603/overview

arinurkkala commented 2 years ago

Investigating

arinurkkala commented 2 years ago

Could you expand on the issue a bit more? Hilma doesn't show any information about national thresholds in the public UI. The referenced link just shows a notice with given data. Currently Hilma does not validate national thresholds for notices at service level.

anttiremes commented 2 years ago

kuva

anttiremes commented 2 years ago

we didn't send boolean about treshold and it seem to be default true in Hilma

arinurkkala commented 2 years ago

image The law requires the boolean to be sent. The data hasn't defaulted to true, only the UI defaults null to true.. will investigate how this case should be handled with Hansel.

arinurkkala commented 2 years ago

Quoting the part from law to which this relates to: 102 § Hankintailmoituksen sisältö "4) hintahaarukka tai ennakoitu arvo ilman arvonlisäveroa taikka tieto siitä, onko hankinnan ennakoitu arvo vähintään 25 §:ssä tarkoitetun kansallisen kynnysarvon suuruinen;"

We will fix Hilma UI to hide the boolean flag when not required ASAP.

Petteri tested in your test environment by hiding the value (disagreeToBePublished = true) and the boolean (doesNotExceedNationalThreshold) was still not sent: https://koulutus.hankintailmoitukset.fi/fi/public/procurement/27524/notice/33696/overview

This case should be fixed on your part, as it shows neither a value nor the boolean.