search

Hankintailmoitukset / hilma-api

11 stars 0 forks source link

OPT-301-Part-EnvironLegis, OPT-301-Part-FiscalLegis, OPT-301-Part-EmployLegis are mandatory in subtype 6 in SDK 1.7 but not in HILMA #195

Closed jlouvrier closed 8 months ago

jlouvrier commented 1 year ago

Customers reported some discrepancies between our implementation of some roles and what they experienced in HILMA.

OPT-301-Part-EnvironLegis, OPT-301-Part-FiscalLegis, and OPT-301-Part-EmployLegis

These 3 OPTs are mandatory in subtype 6 in SDK 1.7. See documentation: https://docs.ted.europa.eu/eforms/1.7/schema/parties.html#_roles_notices (table 10)

It seems that they are not mandatory in HILMA. Could you confirm? Explain?

exttuosa commented 1 year ago

All three are mandatory for subtype 6. However, only the touchpoint/company ID is required. All of the other fields, such as name, email or web address, are not. Hilma initializes an empty touch point for these fields, but does not require any of the information fields to be filled.

jlouvrier commented 1 year ago

And may I ask what is the point of doing what you are doing?

On Tue, Oct 3, 2023 at 10:41 AM exttuosa @.***> wrote:

All three are mandatory for subtype 6. However, only the touchpoint/company ID is required. All of the other fields, such as name, email or web address, are not. Hilma initializes an empty touch point for these fields, but does not require any of the information fields to be filled.

— Reply to this email directly, view it on GitHub https://github.com/Hankintailmoitukset/hilma-api/issues/195#issuecomment-1744379202, or unsubscribe https://github.com/notifications/unsubscribe-auth/APO4CUG3ZMEESHRLLZXRUMDX5O6SDAVCNFSM6AAAAAA5QOJLEGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBUGM3TSMRQGI . You are receiving this because you authored the thread.Message ID: @.***>

exttuosa commented 1 year ago

Currently this is purely based on the SDK. The only required information is the technical Id, which user has no access to and is filled by the system. All the other fields and their mandatoriness are based on the SDK.

Juhisee commented 1 year ago

I see your point there @jlouvrier also on the same page https://docs.ted.europa.eu/eforms/1.7/schema/parties.html#_general_structure_of_an_organization_related_information Under table 4 it's mentioned that only Url is mandatory information for these roles, however in SDK even that is not required. Though I would believe it will be at some point in future SDK versions. I will delived your concern, thank you!