search

Hankintailmoitukset / hilma-api

11 stars 0 forks source link

BT-507 validation is wrong #199

Closed eduardsmirnov closed 11 months ago

eduardsmirnov commented 11 months ago

Attempting to validate a notice containing an Organization with a Country=Israel and missing NUTS code gives us an error "CountrySubentityCode cannot be empty for company ...". It comes from ENoticeValidator.cs, ValidateBT507OrganizationCompany(). This code expects all companies to have a NUTS code. However, Israel does not have NUTS codes so this condition cannot be valid.

Please fix it it ASAP as our customer cannot publish a notice due to this issue.

arinurkkala commented 11 months ago

Investigating

arinurkkala commented 11 months ago

Fix incoming. Should be in prod in ~30 min

arinurkkala commented 11 months ago

Fix should now be in production. BT507 validation was removed.

eduardsmirnov commented 11 months ago

Seems to work, I was able to submit a notice. You could close this one.

arinurkkala commented 11 months ago

Closed