Notice validation - change notice

OlliSurakka commented 7 months ago

In test environment: https://testi.hankintailmoitukset.fi/fi/preview/procedure/11756/enotice/13576/

Test notice Testihankinta15122023_Eliite is published. The user has created a new notice to make changes to this notice. Notice has been created to test environment as a draft through SC Software API.

To Reproduce Steps to reproduce the behavior:

Testnotice Testihankinta15122023_Eliite is published.
The user has created a new notice to make changes to this notice. Notice has been created to test environment as a draft through SC Software API.
All mandatory fields are filled and the user wants to publish the new notice with changes.
In the preview the notice can't be published because of validation errors. (Image)
The same problem occurred also earlier https://testi.hankintailmoitukset.fi/fi/preview/procedure/11162/enotice/12995/. (image)

Expected behavior The validation is ok and the user can publish the notice.

JuhaHakli commented 7 months ago

I'll start looking into this. I'll inform you on the progress.

JuhaHakli commented 7 months ago

There had been a bug earlier about the fields that this is concerning, but the fix was not yet pushed to test. I was unable to recreate the problem using the new release and the data you have in these notices. Could you try again, now that test has been updated with latest fixes?

If you get the same problem again, then please also send the post-body, so we can recreate the steps more accurately.

Havunen commented 6 months ago

The test environment has been updated, are you still experiencing this issue?

OlliSurakka commented 6 months ago

Tested this several times and the following validation problem appears.

https://testi.hankintailmoitukset.fi/fi/preview/procedure/13632/enotice/15534/

The following steps are needed to create the problem:

Notice has been created to test environment as a draft through API.
All mandatory fields are filled and the user wants to publish the notice
The user opens the preview
The notice can't be published because of validation errors.
The user goes back to modify notice but doesn't change anything.
The user goes back to preview -> No more validation problems.

Havunen commented 5 months ago

@OlliSurakka

Can you provide us the request body for the draft notice please

Havunen commented 5 months ago

@OlliSurakka

Does this issue reproduce constantly with some draft notice or was it something that happened once? The fix what Juha did previously was so that it fixes the data once the user opens the problematic page, but it shouldn't reproduce anymore at least I cannot reproduce it. As the data gets fixed once user fills the page

OlliSurakka commented 5 months ago

We are experiencing this issue constantly (first publication, publication with changes to original notice, award notice).

Enclosed are data sent to API and data read from API, when draft notice is filled in Hilma. sent.json read.json

Havunen commented 5 months ago

@OlliSurakka

I still cannot reproduce the issue, What else needs to be done than sending the draft notice through API ( as in sent.json ) and filling the notice and publishing it? I tried creating change notice and CAN from that notice but it does not reproduce the problem :/

PS. I sent you email with video attachment

Havunen commented 4 months ago

The fix is in production

Hankintailmoitukset / hilma-api

Notice validation - change notice #205