search

Hankintailmoitukset / hilma-api

11 stars 0 forks source link

URGENT - Validation errors when submitting 1.7 notices to HILMA in production #214

Closed jlouvrier closed 2 months ago

jlouvrier commented 3 months ago

Hi Ari,

All our forms are failing after submission to HILMA. It looks like the forms are validated against 1.10, but we are still sending in 1.7.

See for example b31054a3-2c75-4ab3-8e30-4013afa44f82-01

Could you please get back to us as soon as possible?

Best, Julien

arinurkkala commented 3 months ago

On it.

-Ari From: Julien Louvrier @.> Sent: perjantai 12. huhtikuuta 2024 12.02 To: Hankintailmoitukset/hilma-api @.> Cc: Subscribed @.***> Subject: [Hankintailmoitukset/hilma-api] URGENT - Validation errors when submitting 1.7 notices to HILMA in production (Issue #214)

Hi Ari,

All our forms are failing after submission to HILMA. It looks like the forms are validated against 1.10, but we are still sending in 1.7.

See for example b31054a3-2c75-4ab3-8e30-4013afa44f82-01

Could you please get back to us as soon as possible?

Best, Julien

- Reply to this email directly, view it on GitHubhttps://github.com/Hankintailmoitukset/hilma-api/issues/214, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOLE6MF36ZUZFK6F54QKDSDY46PHNAVCNFSM6AAAAABGDYH752VHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZTSNBXGE4DQMI. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>

jlouvrier commented 3 months ago

Also experiencing errors when submitting a notice after fixing it even though we always increase the version number when resubmitting. Hilma API Error","title":"Duplicate entry error","status":409,"detail":"A record with same value already exists!","traceId":"2e290a574d2aa3b74af2d96bb5159aeb

arinurkkala commented 3 months ago

TED validator uses the SDK version defined in the EForms CustomizationID. Still investigating if there's something else..

-Ari From: Julien Louvrier @.> Sent: perjantai 12. huhtikuuta 2024 12.02 To: Hankintailmoitukset/hilma-api @.> Cc: Subscribed @.***> Subject: [Hankintailmoitukset/hilma-api] URGENT - Validation errors when submitting 1.7 notices to HILMA in production (Issue #214)

Hi Ari,

All our forms are failing after submission to HILMA. It looks like the forms are validated against 1.10, but we are still sending in 1.7.

See for example b31054a3-2c75-4ab3-8e30-4013afa44f82-01

Could you please get back to us as soon as possible?

Best, Julien

- Reply to this email directly, view it on GitHubhttps://github.com/Hankintailmoitukset/hilma-api/issues/214, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOLE6MF36ZUZFK6F54QKDSDY46PHNAVCNFSM6AAAAABGDYH752VHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZTSNBXGE4DQMI. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>

jlouvrier commented 3 months ago

Yes, and the customization ID for our notices currently is 1.7. We will move to 1.10 asap - we found a small bug a couple of days ago preventing us from going live with 1.10 on the same day as you guys.

arinurkkala commented 3 months ago

Found the bug. During the publish phase, it was sent using SDK 1.10. Sorry for the inconvenience. Fix in prod ~30 minutes

-Ari From: Julien Louvrier @.> Sent: perjantai 12. huhtikuuta 2024 12.24 To: Hankintailmoitukset/hilma-api @.> Cc: Ari Nurkkala @.>; Comment @.> Subject: Re: [Hankintailmoitukset/hilma-api] URGENT - Validation errors when submitting 1.7 notices to HILMA in production (Issue #214)

Yes, and the customization ID for our notices currently is 1.7. We will move to 1.10 asap - we found a small bug a couple of days ago preventing us from going live with 1.10 on the same day as you guys.

- Reply to this email directly, view it on GitHubhttps://github.com/Hankintailmoitukset/hilma-api/issues/214#issuecomment-2051379303, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOLE6MALVS5GALDQNLOI7V3Y46R2PAVCNFSM6AAAAABGDYH752VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJRGM3TSMZQGM. You are receiving this because you commented.Message ID: @.**@.>>

jlouvrier commented 3 months ago

@arinurkkala Thank you for your swift action. Please let us know as soon as the fix is in production, we have plenty of notices awaiting to be resubmitted.

jlouvrier commented 3 months ago

@arinurkkala What about the following error: Hilma API Error","title":"Duplicate entry error","status":409,"detail":"A record with same value already exists!","traceId":"2e290a574d2aa3b74af2d96bb5159aeb

arinurkkala commented 3 months ago

I'll look into this as well

arinurkkala commented 3 months ago

@arinurkkala Thank you for your swift action. Please let us know as soon as the fix is in production, we have plenty of notices awaiting to be resubmitted.

Fix should now be in production.

arinurkkala commented 3 months ago

@arinurkkala What about the following error: Hilma API Error","title":"Duplicate entry error","status":409,"detail":"A record with same value already exists!","traceId":"2e290a574d2aa3b74af2d96bb5159aeb

It appears you are sending a new EtsIdentifier for each version, so Hilma understands it as a new notice. It then throws an exception, because a notice with the same GUID already exists. For resubmitting, you should use the same EtsIdentifier (in this case the version 1).

jlouvrier commented 3 months ago

@arinurkkala We always do a version increase when resubmitting. We submit the same ID, but we increase the version -01, -02 etc... It has never been an issue until this morning.

Earlier today we submitted this one: 26f5bbfc-34d1-4a7e-b415-43b8d55da781-01. It failed due to 1.7 / 1.10 issue. It was resubmitted as : 26f5bbfc-34d1-4a7e-b415-43b8d55da781-02 and is getting the "Duplicate entry error".

Can you investigate further on your end?

arinurkkala commented 3 months ago

Inside the EForms, yes it should be increased. Byt the EtsIdentifier -query param should not change, as it is the same notice from Hilma perspective. If you want a quick fix, we can do a hard delete for the notices that are currently in that state? From logs, I could find these notices: 'd001bff3-22e0-4164-84e8-c51378ad7ba5' 'aa60cae1-d81d-4646-88ce-e4e1abe04182' 'bfd16dc9-0c73-4970-9340-b75eba7b3d90' '26f5bbfc-34d1-4a7e-b415-43b8d55da781' 'c2a065a6-b583-462b-8b54-2b702f658a6c' 'b31054a3-2c75-4ab3-8e30-4013afa44f82' '15317398-e7b0-486c-9cb7-843de890d5ef' '7827bd44-fac6-4df7-9f16-ee63af39932d' '927e04da-9f7e-422d-aeae-24b2bada2162'

jlouvrier commented 3 months ago

Yes, that would be very helpful. Please go ahead!

arinurkkala commented 3 months ago

The notices listed above have been hard deleted. You may resubmit them.

arinurkkala commented 2 months ago

Verified that all notices have been successfully resubmitted. Closing issue.