search

Hankintailmoitukset / hilma-api

11 stars 0 forks source link

BT-15, field loses prior data #215

Closed OlliSurakka closed 2 months ago

OlliSurakka commented 3 months ago

There is a problem with field BT-15 losing the prior data in the Hilma UI.

Steps:

  1. Draft notice is created through draft API (ef16 tested)
  2. In the field BT-15 (url) the imported data from SC Software is shown correctly. Data can be saved and works normally.
  3. The user moves to Ilmoitukset tiedot -tab and saves.
  4. The user moves back to Ilmoituksen yleiset tiedot-tab.

Actual:

The prior saved data in the field BT-15 is missing.

Expected:

The prior saved data in the field BT-15 is not missing.

A video about the problem is enclosed.

https://github.com/Hankintailmoitukset/hilma-api/assets/146176930/ae2635c6-0cbe-44f7-a145-5845a031d2de

arinurkkala commented 3 months ago

Investigating

arinurkkala commented 3 months ago

Fix coming to test. ETA ~50 min.

arinurkkala commented 3 months ago

Fix has been in Test and Dev for some time.. we had some meetings in the meanwhile. Can you confirm if this is fixed?

OlliSurakka commented 3 months ago

Tested with two different testnotices (ef16) -> The problem still exist: data is lost when the user moves to Ilmoitukset tiedot -tab and saves.

arinurkkala commented 3 months ago

Just to be sure - the fix was to Hilma UI and it requires that you have the latest bundle. Did you try Ctrl + F5 and then test?

OlliSurakka commented 3 months ago

Yes, problem still exist after Ctrl + F5

arinurkkala commented 3 months ago

Can you provide the JSON, so I can try to reproduce the issue?

OlliSurakka commented 3 months ago

Here is example for JSON

eFormsEsimerkki.json

arinurkkala commented 3 months ago

There is a second fix in DEV -environment. Could you test it there? Also deploying to staging at the moment.

arinurkkala commented 3 months ago

TEST -environment has also been updated with these changes.

OlliSurakka commented 3 months ago

Tested with ef16 in test environment. Problem still exist (video). Also now field BT-18 makes an error after moving to Osa-välilehti (image).

https://github.com/Hankintailmoitukset/hilma-api/assets/146176930/66ab4e11-bc57-4b7e-a1ca-cfa4846af7af

BT-18
arinurkkala commented 3 months ago

There was an issue with out cleaner that turned out to be an issue. I have made another fix.. sorry for the nth time this has been fixed. Hopefully now it is ok?

OlliSurakka commented 2 months ago

Yes, this is ok and fixed, thank you!