Closed pgoodling-usgs closed 2 years ago
Dear @pgoodling-usgs , thank you for your feedback! Could you rerun your code with tuneGrid without the dots?
tuneGrid<- data.frame( mtry = c(2,5,7), splitrule = "variance", min.node.size = c(5))
The current behavior is that mtry is set to the maximum number of predictors in each round of the ffs - so I guess it works as intended?
Greetings, Marvin
Hi @Ludwigm6,
Sorry, you are correct! I was misunderstanding how the mtry gets fed into the ffs function - I didn't realize that it would rename it automatically.
Best,
Phillip
Thanks for this package, it is very helpful. One point to note:
It looks like the minimum value reset in line 183 of ffs should be
.mtry
instead ofmtry
.When running the example within the ffs function with
method = ranger
, it is clear that the instances with mtry > # of predictors isn't skipped in the same way as when thetuneLength
argument is set. See example below.Created on 2022-04-24 by the reprex package (v2.0.1)