search

HannaMeyer / CAST

Developer Version of the R package CAST: Caret Applications for Spatio-Temporal models
https://hannameyer.github.io/CAST/
108 stars 30 forks source link

W in geodist #69

Closed carlesmila closed 1 year ago

carlesmila commented 1 year ago

@HannaMeyer Added W statistic for test data and/or CV folds in geodist as attributes for type="geo".

@JanLinnenbrink unfortunately we cannot use this implementation for the simulations since geodist doesn't accept ppoints and we need our W to be exactly comparable between CV methods. Will PR to kNNDM_paper ASAP.

HannaMeyer commented 1 year ago

@carlesmila Thanks! I added the W statistic for sample-to-sample as well. I see you limited it to the use of geographic distances. Can't it be used for feature space distances in the same way?

carlesmila commented 1 year ago

It certainly can, but I thought it'd be better to explore and validate it first prior to providing it, but feel free to disagree :)

HannaMeyer commented 1 year ago

I tested it and it works as expected but I think @JanLinnenbrink is exploring the feature space version of knndm. @JanLinnenbrink let's keep in mind to integrate that once you feel confident with it