Final Grade - Githubissues

Hey there once again, @thomasjbradley.

This project has been such fun. I enjoy getting to take an idea from the design stage through implementation in all our mediums, but when coding I find the challenges so unique that it is particularly satisfying to accomplish. It was especially rewarding to have built something that is not only several pages and operational, but also to have the pieces that would theoretically allow the rest of this site to be coded very quickly, should the need arise.

I think that I've covered as much as is possible for an e-commerce site, maybe short of having additional banner photos ready, to be able to create the extra content needed for launch. There are pieces I did not get to use, and my existing patterns are easily adapted (I have used a great number of includes to piece all of my content together). Though we did not get to test the site with partners, I hope that someone else would be able to use the library to create content. I've explained the elements accurately, and I was testing my patterns for partner trade off before it was announced that we wouldn't be doing that portion, to ensure it would be ready.

There are improvements that could be made. I didn't style some standard html elements (specifically tables were notably absent) which could be a problem for unknown pages. There are still ways to display the content with what exists (as I had to do with my first surprise page) but this might not be as easy to hand off.

Ultimately, I found this process very fun. I feel like I gained more concrete knowledge of how hosting platforms work, and I've very much enjoyed learning new language syntaxes and about includes (AMAZING). I am not sure how often I will get the opportunity to create something from scratch like this, so have really appreciated the opportunity here.

Style & design — 3

The pages are consistent, with the use of my banner patterns and through the multiple hand drawn pieces. They were fun to create and I think add a great deal of charm to the site, especially since the items for sale are fun, specialty items. I think the design is appropriate and ideal for a small family run honey business.

Patterns — 3

I didn't get to use all of the patterns I made (specifically the page number carousel clicker, I would have liked to use it though). The variable nature of the patterns would allow multiple additional functions, that would remain on brand, for additional pages. I also had an entire extra section created for an email subscribe banner, which was not in my original design, that I wound up being able to use on the second surprise page. I was pleased to have that ready.

Explanations — 3

Though we were ultimately unable to know for sure by doing the partner work, I made sure that all of my config files were very descriptive, so that the library is easy to navigate. I also think that my patterns are easy to recognize distinctly, so that another person could identify which to use if they were presented with wireframes.

Accessibility — 3

I spent extra energy ensuring that this site would be accessible. I have skip-links included on my default page and as my pages are very image based, I designed the site to still display in a visually pleasing way if no images display. I also found images that would work with my card overlays very specifically, so that the brown and yellow were always showing on an appropriate image for contrast.

Semantics — 2

As detailed in my surprise page one hand in, I think that could have styled more, and my set up could have been a bit better within my heading elements. They are just not too different from each other. I think this is one fault in an otherwise well set up site, but it did take some extra energy to make these pieces display in a visually pleasing way on the legal page, which wouldn't be ideal if handing the library off to someone else.

Responsiveness — 3

The card/banner overlay gave me some troubles at various points, but I spent a lot of time making sure they worked at every screen size, including on a phone in landscape (a relatively new, last minute discovery!). The masthead and footers are very responsive, and I've made some patterns, like the sidebar that shows cart contents on the product page, become hidden at smaller sizes in order to display better.

Code quality — 3

I'm very pleased with the way this site is set up. I learned a lot about using includes and also applying Liquid elements to manipulate my content even further. I'm particularly happy about how the page: category line has been used in my breadcrumbs, card content and especially, the product pages banners! The banner image changes based on whether the page features a Honey, Body or Candle categorized product. This took some finicky work that I think paid off tremendously.

Git and Commits — 3

My commit messages are pretty consistent and direct. While working on this project there were a few times where I did not commit between several tasks (not ideal). I took the extra time to go through all the files and uncheck certain changes, so that my commits would remain chronological and based on each lesson as they were completed. After doing this a couple times, my commits became more frequent for sure! I committed many times.

23/24 — 96%

HannahDelaney / ecommerce-pattern-library

Final Grade #13