Multiple track circuits don't always work and cause bug

HannahNBogen / OpenRCT2

An open source re-implementation of RollerCoaster Tycoon 2 🎢

https://openrct2.io

GNU General Public License v3.0

0 stars 0 forks source link

Multiple track circuits don't always work and cause bug #6

Closed HannahNBogen closed 4 years ago

HannahNBogen commented 4 years ago

Windows 10

Multiple circuits is not supported and when trying to switch from using multiple circuits to using one circuit, I didn't think the switch was occurring, causing a bug.

[ ] Reproducible in RCT2 (vanilla)?
[ ] Specific to multiplayer?

HannahNBogen commented 4 years ago

Issue not quite fixed

HannahNBogen commented 4 years ago

Multiple circuits not supported and causes bug

HannahNBogen commented 4 years ago

Fixed - 073715fc7b4a299131aa10d66278b5249dbca58d

HannahNBogen commented 4 years ago

I tested this one again and the problem is still occurring. @lshearer20 @kathyfreund can you see?

kathyfreund commented 4 years ago

Is this the one you were showing us yesterday?

HannahNBogen commented 4 years ago

Yes

kathyfreund commented 4 years ago

Wouldn't hurt to put an else in there in the case that CanHaveMultipleCircuits, that way you can call the setter again? I'm not too sure how you determine the number of circuits or if it's even a smart idea to redefine them within this check

kathyfreund commented 4 years ago

I just tried it and it seems to be working for me?

HannahNBogen commented 4 years ago

I'm dumb I was looking at a track that has multiple circuits, it is working, phew! Thanks anyway