search

HannahVMeyer / PhenotypeSimulator

Other
28 stars 7 forks source link

getCausalSNPs() doesn't identify single causal SNP #13

Closed SarahNadeau closed 5 years ago

SarahNadeau commented 5 years ago

getCausalSNPs() does not identify which SNP is causal when only a single causal SNP is specified. To demonstrate the problem:

getCausalSNPs(NrCausalSNPs = 1, ...) gives: [,1] ID_1 0 ID_2 0 ID_3 0

while getCausalSNPs(NrCausalSNPs = 2, ...) gives the more helpful: SNP_6 SNP_7 ID_1 0 0 ID_2 0 0 ID_3 0 0

I believe this problem is a result of this line in the getCausalSNPs function: causalSNPs <- genotypes$genotypes[, sort(sample(ncol(genotypes$genotypes), NrCausalSNPs))]

HannahVMeyer commented 5 years ago

Hi Sarah,

thank you for pointing this out. I have fixed the issue now.

Hannah

SarahNadeau commented 5 years ago

Great, thanks so much!

On 13 May 2019, at 18:24, HannahVMeyer notifications@github.com wrote:

Hi Sarah,

thank you for pointing this out. I have fixed the issue now.

Hannah

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/HannahVMeyer/PhenotypeSimulator/issues/13?email_source=notifications&email_token=AHH5AMGINCTKSBAJECCF2PDPVGI4RA5CNFSM4HLABWB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVI23BI#issuecomment-491892101, or mute the thread https://github.com/notifications/unsubscribe-auth/AHH5AMFHIWC4WG5EEY33ODLPVGI4RANCNFSM4HLABWBQ.