HannahVMeyer / PhenotypeSimulator

Other
28 stars 7 forks source link

Distribution of SNP Effects #22

Open beatrixOngit opened 4 years ago

beatrixOngit commented 4 years ago

Is your feature request related to a problem? Please describe. We are looking to incorporate the ability to enter a user-defined distribution of SNP effects. The purpose of this being to make the simulation as close to the real species as possible.

Describe the solution you'd like Looking for a way to allow other distributions for SNP fixed effects other than uniform and normal? Specifically the geometric distribution. Alternatively, if this already exists, could you explain which parameter we can access this through? Describe alternatives you've considered We like the application PhenotypeSimulator most of all others we have tried - meets all our criteria but this one.

HannahVMeyer commented 4 years ago

Thanks for your interest in the package. At the moment, only uniform and normal SNP effect distributions are implemented.

Allowing different distributions is straight forward for the independent SNP effects. However, for the shared SNP effects we use a multiplicative approach to simulate normal and uniform distribution. From the methods section of the publication:

image

I will have a look into possibilities to incorporate other distributions, but this will unfortunately not be a priority now. Any suggestions for implementation of the geometric distribution from your side are welcome