HansKristian-Work / vkd3d-proton

Fork of VKD3D. Development branches for Proton's Direct3D 12 implementation.
GNU Lesser General Public License v2.1
1.91k stars 199 forks source link

Alan Wake II - Textures are missing #1754

Closed DomiStyle closed 1 year ago

DomiStyle commented 1 year ago

As mentioned in https://github.com/HansKristian-Work/vkd3d-proton/issues/1753#issuecomment-1783597078

Textures in Alan Wake II are "missing". See screenshots for details.

20231027214931_1

20231027220156_1

For comparison from a Youtube playthrough: image

Software information

Alan Wake II, on any settings.

System information

Log files

steam-18084208946599428096.log

Log file shows game start, ingame and game exit.

baryluk commented 1 year ago

Is there any way we can do this for flatpaks? In flatpak I have 23.1.9 and can't get latest mesa-git, I can get to 23.3.0 but that's installing mesa-git of flathub-beta.

Just be patient. The MR in Mesa will be merged soon, and then it will be available easier.

blimp4242 commented 1 year ago

Hey there, same happened to me, 7900XT on Arch. I applied the patch to commit edfbf74df1d4d6ce54ffe24566108be0e1a98c3d (~2 weeks old) and this fixed it for me.

Thanks for the info, i tried applying the patch right after applying the "25659.patch" by running: curl -sL https://gitlab.freedesktop.org/mesa/mesa/-/commit/edfbf74df1d4d6ce54ffe24566108be0e1a98c3d.patch | git am

But i get this error message:

Applying: dri: Drop a duplicate mesa vs pipe format table.
error: patch failed: src/gallium/frontends/dri/dri_screen.c:438
error: src/gallium/frontends/dri/dri_screen.c: patch does not apply
Patch failed at 0001 dri: Drop a duplicate mesa vs pipe format table.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

I'm probably doing it wrong

TheAnnoyingFruit commented 1 year ago

Sorry to ask for a lot here but would someone be able to explain the easiest way I can go about doing this

kkoniuszy commented 1 year ago

Hey there, same happened to me, 7900XT on Arch. I applied the patch to commit edfbf74df1d4d6ce54ffe24566108be0e1a98c3d (~2 weeks old) and this fixed it for me.

Thanks for the info, i tried applying the patch right after applying the "25659.patch" by running: curl -sL https://gitlab.freedesktop.org/mesa/mesa/-/commit/edfbf74df1d4d6ce54ffe24566108be0e1a98c3d.patch | git am

But i get this error message:

I'm probably doing it wrong

@blimp4242 You need to go back to commit edfbf74 and then apply the patch on top of that, like this:

$ git checkout edfbf74
Note: switching to 'edfbf74'.
...

$ curl -sL https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25659.patch | git am
Applying: radv: call lower_array_deref_of_vec before lower_io_arrays_to_elements
Applying: radv: skip radv_remove_varyings for mesh shaders
blimp4242 commented 1 year ago

@blimp4242 You need to go back to commit edfbf74 and then apply the patch on top of that, like this:

$ git checkout edfbf74
Note: switching to 'edfbf74'.
...

$ curl -sL https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25659.patch | git am
Applying: radv: call lower_array_deref_of_vec before lower_io_arrays_to_elements
Applying: radv: skip radv_remove_varyings for mesh shaders

Actually worked, even if i got an error at compile time, thank you so much.

juampiursic commented 1 year ago

Is there any way we can do this for flatpaks? In flatpak I have 23.1.9 and can't get latest mesa-git, I can get to 23.3.0 but that's installing mesa-git of flathub-beta.

Just be patient. The MR in Mesa will be merged soon, and then it will be available easier.

EDIT: Tried it with non-flatpak Bottles, got it working with mesa 24.0.0 and the MR 25659. FBI on jackets are showing, textures are good. FPS drop down was an issue on my end.

fakhraldin commented 1 year ago

Anyboy still experiencing fps drop downs with latest mesa-git 24.x.x devel or is commit edfbf74df1d4d6ce54ffe24566108be0e1a98c3d mandatory to workaround the fps drops?

FPS drop down was an issue on my end.

Are your sure about that? Because two other people reported the fps drop to be only resolved in combo with commit edfbf74...

baryluk commented 1 year ago

@fakhraldin MR 25659 patch ( https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25659.patch ) , applies fine and cleanly on current mesa-git main branch (at 4f892ecc1e143c42a41d32450262e799d4d152af ), and works fine for me. I do not know what edfbf74 is, and it is not in my git log. I think edfb74 was part of https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25650 , but that is already merged to current mesa-git main branch.

edfbf74df1d4d6ce54ffe24566108be0e1a98c3d is also not relevant to radv or performance. It is something unrelated.

fakhraldin commented 1 year ago

@fakhraldin MR 25659 patch ( https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25659.patch ) , applies fine and cleanly on current mesa-git main branch (at 4f892ecc1e143c42a41d32450262e799d4d152af ), and works fine for me. I do not know what edfbf74 is, and it is not in my git log. I think edfb74 was part of https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25650 , but that is already merged to current mesa-git main branch.

edfbf74df1d4d6ce54ffe24566108be0e1a98c3d is also not relevant to radv or performance. It is something unrelated.

Thank you for your kind reply, clarfiying the situation for me. The previous statements on this confused me.

juampiursic commented 1 year ago

FPS drop down was an issue on my end.

Are your sure about that? Because two other people reported the fps drop to be only resolved in combo with commit edfbf74...

I'll further test it but it seems so. I have multiple CoreCTRL profiles and I was using the chill one, where I set fans to not spin and performance mode on automatic, so GPU was drawing 90w, set it to the one where I have power limit at max, which is 323w and then it begin to draw 290w and FPS normalize.

Think I butchered the quote, just in case I'll tag you here @fakhraldin

TheAnnoyingFruit commented 1 year ago

I am completely lost. If anyone can help it would be much appreciated. I can provide contact info to avoid spamming this issue thread

Kombatant commented 1 year ago

Latest mesa-git and patch 25659 solves the texture issue for me as well. But I also get a performance tank (as in, 5fps, unplayable). As soon as I do VKD3D_DISABLE_EXTENSIONS=VK_EXT_mesh_shader, performance goes up to playable levels. So there might be a second issue here.

fakhraldin commented 1 year ago

I am completely lost. If anyone can help it would be much appreciated. I can provide contact info to avoid spamming this issue thread

Have a look at my git repo.

juampiursic commented 1 year ago

Anyboy still experiencing fps drop downs with latest mesa-git 24.x.x devel or is commit edfbf74df1d4d6ce54ffe24566108be0e1a98c3d mandatory to workaround the fps drops?

FPS drop down was an issue on my end.

Are your sure about that? Because two other people reported the fps drop to be only resolved in combo with commit edfbf74...

Here are my specs:

5600X
16GB RAM
6900XT

fedora 39
mesa 24.0.0 with 25659 patch
vkd3d-proton-master

Game running at 1440p, high preset, with native rendering res, and I'm getting about 60FPS Game running at 1440p. high preset with quality rendering res and I'm getting about 90-105FPS

As far as I can tell, just playing the initial scene, I don't get FPS drops and performance is the same as it's on Windows, although I did not test that, just going about a video I saw with same specs, 5600X and 6900XT at 1440p.

This is a video I recorded using GPU Screen Recorder:

https://youtu.be/H0wbrVKc4Lk

And this is the video I found on YouTube, same specs but on Windows:

https://www.youtube.com/watch?v=FhPwGoBzr70

juampiursic commented 1 year ago

Latest mesa-git and patch 25659 solves the texture issue for me as well. But I also get a performance tank (as in, 5fps, unplayable). As soon as I do VKD3D_DISABLE_EXTENSIONS=VK_EXT_mesh_shader, performance goes up to playable levels. So there might be a second issue here.

Wow, I'm the other way around. I tried with VKD3D_DISABLE_EXTENSIONS=VK_EXT_mesh_shader, also with latest mesa-git and patch 25659 and my FPS took a real hit, got about 30FPS 1440p, all high, where without the mesh shader disabled I get around 60FPS and 90-100FPS FSR2 Quality.

TheAnnoyingFruit commented 1 year ago

I am completely lost. If anyone can help it would be much appreciated. I can provide contact info to avoid spamming this issue thread

Have a look at my git repo.

you are awesome

TheAnnoyingFruit commented 1 year ago

@fakhraldin following your instructions unfortunately for me when using the patched mesa I just get a black screen when I launch the game

kkoniuszy commented 1 year ago

@fakhraldin MR 25659 patch ( https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25659.patch ) , applies fine and cleanly on current mesa-git main branch (at 4f892ecc1e143c42a41d32450262e799d4d152af ), and works fine for me. I do not know what edfbf74 is, and it is not in my git log. I think edfb74 was part of https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25650 , but that is already merged to current mesa-git main branch.

edfbf74df1d4d6ce54ffe24566108be0e1a98c3d is also not relevant to radv or performance. It is something unrelated.

@baryluk Yes, that commit was merged and it's unrelated. What some users are saying is that on the current main branch they get performance issues, but going back to that commit and applying the patch after it fixes it, that is: there might be a regression that worsens performance somewhere between edfbf74 and the current main branch. It's not exactly edfbf74 and affected users could do a git bisect to find the actual bad commit.

Also, some of the MRs I originally mentioned were performance related: mesa MR 25890 and vkd3d MR #1749 enable DGC for mesh shaders, which could improve performance. Anyone who is experiencing performance issues could also try these. FWIW, I'm still using all the MRs I mentioned in my previous comment, on top of the current main branch. No performance issues on a RX6800XT + 5800X3D setup.

dao-ken commented 1 year ago

Latest mesa-git and patch 25659 solves the texture issue for me as well. But I also get a performance tank (as in, 5fps, unplayable). As soon as I do VKD3D_DISABLE_EXTENSIONS=VK_EXT_mesh_shader, performance goes up to playable levels. So there might be a second issue here.

Wow, I'm the other way around. I tried with VKD3D_DISABLE_EXTENSIONS=VK_EXT_mesh_shader, also with latest mesa-git and patch 25659 and my FPS took a real hit, got about 30FPS 1440p, all high, where without the mesh shader disabled I get around 60FPS and 90-100FPS FSR2 Quality.

You should remove VKD3D_DISABLE_EXTENSIONS=VK_EXT_mesh_shader because applying patch 25659 to mesa-git, adds Mesh Shader support.

HansKristian-Work commented 1 year ago

Not a vkd3d-proton bug. Fixed by Mesa MRs, so closing this. The vkd3d-proton issue tracker is not a forum for how to build Mesa flatpaks.