search

HansKristian-Work / vkd3d-proton

Fork of VKD3D. Development branches for Proton's Direct3D 12 implementation.
GNU Lesser General Public License v2.1
1.76k stars 184 forks source link

vkd3d: Remove Cyberpunk 2077 shader quirks #1934

Closed pixelcluster closed 4 months ago

pixelcluster commented 4 months ago

The bug has been fixed game-side. Yay!

Joshua-Ashton commented 4 months ago

Is it worth removing these? If they have new shaders, then this should only trigger on the older versions?

pixelcluster commented 4 months ago

Yeah, I don't think the quirks get triggered anymore. But do we really want to keep essentially dead workarounds for outdated versions of the game? I don't think we expect any users to run game versions 2.0-2.11 anymore (the issue started appearing in 2.0 and has been fixed in 2.12 IIRC).

Some people might still use the 1.x branch from before Phantom Liberty released because 2.0 raised system requirements, but the issue doesn't appear there either.

Joshua-Ashton commented 4 months ago

Yeah, mainly just thinking of modders/speedrunners given that game has a big scene there.

shelterx commented 4 months ago

My thought is just why not just add a comment on what versions those workarounds are for and saying it's fixed from version x.x. instead.

HansKristian-Work commented 4 months ago

Yeah, mainly just thinking of modders/speedrunners given that game has a big scene there.

Is there any evidence speedrunners are targeting >= 2.0 && <= 2.11? Why would they play with DXR on? And if they lock to specific versions, any reason why they cannot use specific vkd3d-protons versions as well?

I don't think we should keep legacy workarounds around longer than they reasonably have to exist.

doitsujin commented 4 months ago

Agree that we should remove the workaround if this has been fixed in game.

HansKristian-Work commented 4 months ago

Ok, let's do that then.