search

HansKristian-Work / vkd3d-proton

Fork of VKD3D. Development branches for Proton's Direct3D 12 implementation.
GNU Lesser General Public License v2.1
1.75k stars 183 forks source link

Arma Reforger: map is invisible when using "hardware antialiasing" option #2001

Closed OlegAckbar closed 1 month ago

OlegAckbar commented 1 month ago

Software information

"Hardware antialiasing" option causes the map to not draw in Arma Reforger. Disabling this option makes the map visible again Here's a screenshot with "Hardware antialiasing" set to "x2": Снимок экрана_20240528_201128 Here's a screenshot with "Hardware antialiasing" disabled: Снимок экрана_20240528_201117

System information

Log files

steam-1874880.log

doitsujin commented 1 month ago

Does this even work on Windows? I can reproduce this locally, but the game's MSAA impementation is completely broken, it doesn't set up pipelines correctly, tries to render to images with different sample counts at the same time, and seems to fuck up various copies and resolves. I'm not surprised that this isn't working, but I don't know to which extent we can work around all of these app bugs.

OlegAckbar commented 1 month ago

@doitsujin I can't test it on Windows myself but I found this video https://youtu.be/f1SJCPcTtG4 It's from the 3rd of December but you can see that at 0:11 that he's using x8 hardware antialiasing and at 5:40 his map works fine.

doitsujin commented 1 month ago

Figured out that the game hits some broken-ass fallback path with vkd3d-proton due to a missing format support bit somewhere, investigating.

OlegAckbar commented 1 month ago

I would like to thank you for solving this issue so quickly. Now map indeed works with a hardware antialiasing option. However, another problem showed up. With hardware AA option map appears in low gamma, no such problem with hardware AA turned off. Here's a screenshot with hardware AA turned off: Снимок экрана_20240529_184650 Here's when it's turned to x2 Снимок экрана_20240529_184632

doitsujin commented 1 month ago

Thanks for the heads-up, this is a bug in our resolve code where in one specific edge case we do not properly account for sRGB images. I'll have a fix shortly.

For future reference, please re-open the issue or file a new one for visibility.

OlegAckbar commented 1 month ago

Ok, #2004 indeed fixes the issue. Once it's merged issue should be closed I think?