:broom:, but I dumped most of it into a single commit so let me know if you want this stuff to be split differently.
Adds missing newlines
Adds some dots where appropriate
Removes some stray spaces, in particular at the end of message just before newline and when there was more than one space in the middle of format string
Changes some specifiers to better match argument types
Fixes some conversion specifiers missing their arguments or arguments missing their conversion specifiers
Adds extra arguments to log messages in two places where it would make sense to log them
Two places I'm not sure about are
ERR("DSV: %p\n", graphics->dsv_format); where I don't know if there's any value in logging the pointer value and maybe we should log graphics->dsv_format->dxgi_format or graphics->dsv_format->vk_format here instead (or both?)
RT_TRACE(" RDAT subobject: %s (type #%x).\n", debugstr_w(data->subobjects[j].name), data->subobjects[j].kind); where the comment suggests that the strings might actually be ASCII but IIUC name is actually already post-conversion to WCHAR.
There's also another commit with two NULL checks added (for extension_count) where I found it weird that they are not checked before dereferencing. Finally, last commit attempts to ensure leading zeros are always printed when formatting the build commit message.
:broom:, but I dumped most of it into a single commit so let me know if you want this stuff to be split differently.
Two places I'm not sure about are
ERR("DSV: %p\n", graphics->dsv_format);
where I don't know if there's any value in logging the pointer value and maybe we should loggraphics->dsv_format->dxgi_format
orgraphics->dsv_format->vk_format
here instead (or both?)RT_TRACE(" RDAT subobject: %s (type #%x).\n", debugstr_w(data->subobjects[j].name), data->subobjects[j].kind);
where the comment suggests that the strings might actually be ASCII but IIUCname
is actually already post-conversion toWCHAR
.There's also another commit with two
NULL
checks added (forextension_count
) where I found it weird that they are not checked before dereferencing. Finally, last commit attempts to ensure leading zeros are always printed when formatting the build commit message.