HansKristian-Work / vkd3d-proton

Fork of VKD3D. Development branches for Proton's Direct3D 12 implementation.
GNU Lesser General Public License v2.1
1.75k stars 183 forks source link

Fix multiple issues and inconsistencies in log message formats #2017

Closed Saancreed closed 2 weeks ago

Saancreed commented 2 weeks ago

:broom:, but I dumped most of it into a single commit so let me know if you want this stuff to be split differently.

Two places I'm not sure about are

There's also another commit with two NULL checks added (for extension_count) where I found it weird that they are not checked before dereferencing. Finally, last commit attempts to ensure leading zeros are always printed when formatting the build commit message.

Saancreed commented 2 weeks ago

Can you remove the last commit and start a new PR so we can hash it out there?

Done, I'll submit the other PR in a moment.