Potential bug with EI and StartInstanceLocation

HansKristian-Work / vkd3d-proton

Fork of VKD3D. Development branches for Proton's Direct3D 12 implementation.

GNU Lesser General Public License v2.1

1.83k stars 191 forks source link

Closed HansKristian-Work closed 1 week ago

HansKristian-Work commented 2 weeks ago

Developer reported a buggy case where:

ExecuteIndirect with push constant update is used.
Instanced VBO is used.
StartInstanceLocation is used in the indirect indexed draw call.
It is expected that instanced VBO is offset correctly.
- This does not seem to happen on Deck.

We probably need test coverage here.

GlassBeaver commented 2 weeks ago

Hi, the dev here. The bug only seems to exist on the Beta channel on the Deck - Stable seems to be fine.

hakzsam commented 1 week ago

I'm wondering why Stable/Beta on Deck is different then.

hakzsam commented 1 week ago

Nvm, this commit is fine, I missed "Fixed bug". I think I know when the regression started.

hakzsam commented 1 week ago

https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30971 fixes it and everything makes sense. I will backport it on Beta channel.