search

HansNewbie / coral-repo

Automatically exported from code.google.com/p/coral-repo
0 stars 0 forks source link

Code review request #27

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Define coral::pythonWrapperUtils::pyGILEnsured as an external variable so that 
multiple include of pythonWrapperUtils.h will not cause multiple symbols 
linking error

Original issue reported on code.google.com by Yue.Nich...@gmail.com on 21 Feb 2012 at 1:21

GoogleCodeExporter commented 9 years ago 
Should we wrap it with proper getters and setters?

Original comment by aintergu...@gmail.com on 21 Feb 2012 at 7:20

GoogleCodeExporter commented 9 years ago 
Yes....in case there is any threading issue (race condition) but I don't know 
the use case or original requirement so can't tell at the moment.

In any case, getter/setter is cleaner in the long run.

Go for it.

Original comment by Yue.Nich...@gmail.com on 21 Feb 2012 at 7:42