Hanslick-Online / hsl-app

https://hanslick.acdh.oeaw.ac.at
MIT License
0 stars 0 forks source link

Detailed View of Works and Places (Alternativname) #31

Closed AlexanderWilfing closed 9 months ago

AlexanderWilfing commented 9 months ago

DetailedView The detailed view of people and figures does no longer show the line "Alternativname" if there is no such alt name in Baserow. Could you expand this setting to the detailed view of works and places?

AlexanderWilfing commented 9 months ago

I just noticed that the line "Alternativname" still shows in entries of places even when the field is empty in Baserow. I missed that because most places indeed do have an alt_name. Also, could we do the same for GNDs, i.e. if there is no data, could we hide the respective line in the detailed view of persons and works (especially important in the case of fictional persons, as most of them don't have a GND entry)? Example Example2

AlexanderWilfing commented 9 months ago

Thanks for implementing the changes! Now, however, the detailed view of works does no longer show its author(s), which is desired and worked in the previous release (see example). Please change this again, so the detailed view of works does show the author(s). Sorry for the hassle, but other than that we are good on that front, unless I missed something.

Public App Public

DevApp DevApp

It is good that the line "Alternativname" does no longer show (cause there is none), but the author(s) should be visible, which is especially important in cases where there are different works with the same title (Faust, for example, by Goethe, Liszt, Gounod, Schumann, etc.)