search

Hantonik / AnvilAPI

AnvilAPI is a mod that adds to the game the ability to create your own dream anvil recipes.
https://curseforge.com/minecraft/mc-mods/anvilapi
MIT License
1 stars 1 forks source link

Causes crashes while using on dedicated server due to using client class #29

Closed Huntter99 closed 8 months ago

Huntter99 commented 8 months ago

Issue description:

I have done many tests and after 2 days of testing thing I was honestly so sad to find it is your mod as I'd been looking for a mod like yours for a very long time. I love the mod so much and I really believe your mod will end up being a highly downloaded mod and I really hope this is an easy fix.

Steps to reproduce:

  1. Start server without anvil api = server loads.
  2. Add in anvil api = server crash due to attempting to load net.minecraft.client.Minecraft on dedicated server.
  3. Remove anvil api = server successfully loads again.

AnvilAPI version:

AnvilAPI-1.20.1-forge-4.1.4.0.jar

Minecraft version:

1.20.4

Modloader:

Forge

Modloader version:

47.2.20

The latest.log file:

11Feb2024 21:59:39.710] [main/ERROR] [net.minecraftforge.fml.loading.RuntimeDistCleaner/DISTXFORM]: Attempted to load class net/minecraft/client/Minecraft for invalid dist DEDICATED_SERVER

Hantonik commented 8 months ago

Hello, thank you for reporting the bug. It has already been addressed in version 5.2.1.1-beta (commit 190e6720955f212bed69f6b3160913338d44596b) for Minecraft 1.20.4. Please consider updating to the latest mod version.

Huntter99 commented 8 months ago

Does that work on 1.20.1?

On Mon, Feb 12, 2024, 12:09 PM Hantonik @.***> wrote:

Hello, thank you for reporting the bug. It has already been addressed in version 5.2.1.1-beta (commit 190e672 https://github.com/Hantonik/AnvilAPI/commit/190e6720955f212bed69f6b3160913338d44596b) for Minecraft 1.20.4. Please consider updating to the latest mod version.

— Reply to this email directly, view it on GitHub https://github.com/Hantonik/AnvilAPI/issues/29#issuecomment-1939169465, or unsubscribe https://github.com/notifications/unsubscribe-auth/BEPMZXJ5ANXAVKQWXNVV2H3YTJEETAVCNFSM6AAAAABDD36SS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZZGE3DSNBWGU . You are receiving this because you authored the thread.Message ID: @.***>

Hantonik commented 8 months ago

I'm afraid not. Unfortunately, Mojang doesn't prioritize the compatibility of their changes with mods in subsequent versions. AnvilAPI underwent significant changes when porting from version 1.20.1 to versions 1.20.3 and 1.20.4 to align with Mojang's modifications.

Huntter99 commented 8 months ago

And I'm assuming there's no plan to work on 1.20.1 anymore? Would you be against me trying myself? Idk if you're open source with your code. I would really appreciate it if i could try.

On Mon, Feb 12, 2024, 2:46 PM Hantonik @.***> wrote:

I'm afraid not. Unfortunately, Mojang doesn't prioritize the compatibility of their changes with mods in subsequent versions. AnvilAPI underwent significant changes when porting from version 1.20.1 to versions 1.20.3 and 1.20.4 to align with Mojang's modifications.

— Reply to this email directly, view it on GitHub https://github.com/Hantonik/AnvilAPI/issues/29#issuecomment-1939436302, or unsubscribe https://github.com/notifications/unsubscribe-auth/BEPMZXKDGPGTPHWJXGJPKRLYTJWRFAVCNFSM6AAAAABDD36SS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZZGQZTMMZQGI . You are receiving this because you authored the thread.Message ID: @.***>

Hantonik commented 8 months ago

Sure thing, feel free to fork this repository and work on it independently. The code is under the MIT license. I recommend starting from the commits 190e6720955f212bed69f6b3160913338d44596b and 79ec5d370e1dc07aa3a252ac0ae9d430c551d00d. I fixed most of the dedicated server-related issues in those commits. Once you've resolved the issue and want to incorporate it into an official release, just go ahead and open a pull request.

Huntter99 commented 8 months ago

Awesome thank u so much

On Mon, Feb 12, 2024, 4:17 PM Hantonik @.***> wrote:

Closed #29 https://github.com/Hantonik/AnvilAPI/issues/29 as completed.

— Reply to this email directly, view it on GitHub https://github.com/Hantonik/AnvilAPI/issues/29#event-11779972130, or unsubscribe https://github.com/notifications/unsubscribe-auth/BEPMZXK7WX6YXFL6D63NQPDYTKBF7AVCNFSM6AAAAABDD36SS6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRG43TSOJXGIYTGMA . You are receiving this because you authored the thread.Message ID: @.***>

Huntter99 commented 8 months ago

I am having issues trying to open the respiratory files as a java project i figured out that the issue I'm having is related to using minecraft.world.level vs client for the mixinItem class. This is the only issue I'm seeing.

On Fri, Feb 16, 2024, 4:57 AM Hantonik @.***> wrote:

Closed #29 https://github.com/Hantonik/AnvilAPI/issues/29 as completed.

— Reply to this email directly, view it on GitHub https://github.com/Hantonik/AnvilAPI/issues/29#event-11827403531, or unsubscribe https://github.com/notifications/unsubscribe-auth/BEPMZXINIUQXHX3ZR2FF77TYT43SNAVCNFSM6AAAAABDD36SS6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRHAZDONBQGM2TGMI . You are receiving this because you authored the thread.Message ID: @.***>

Yorunina commented 2 months ago

I am having issues trying to open the respiratory files as a java project i figured out that the issue I'm having is related to using minecraft.world.level vs client for the mixinItem class. This is the only issue I'm seeing. … On Fri, Feb 16, 2024, 4:57 AM Hantonik @.> wrote: Closed #29 <#29> as completed. — Reply to this email directly, view it on GitHub <#29 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BEPMZXINIUQXHX3ZR2FF77TYT43SNAVCNFSM6AAAAABDD36SS6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRHAZDONBQGM2TGMI . You are receiving this because you authored the thread.Message ID: @.>

Sorry to disturb. Is there an existing solution for this issue in 1.20.1?