search

HaoZeke / OpenBLAS

OpenBLAS is an optimized BLAS library based on GotoBLAS2 1.13 BSD version.
http://www.openblas.net
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

BLD: Move config.h creation to `setup` stage #16

Closed mtsokol closed 3 months ago

mtsokol commented 3 months ago

Hi @HaoZeke,

I decided to spend some time to actually move config.h creation to setup stage (with existing getarch, etc.) anyway. It was too annoying to work with manually created files.

This refactor is separate from your config.h work. It's a rework of my previous config.h generation attempt, and it relies on run_commands that are executed in the setup stage.

HaoZeke commented 3 months ago

Looks much cleaner, are the run commands guaranteed to be executed in order in the configuration stage?

mtsokol commented 3 months ago

Looks much cleaner, are the run commands guaranteed to be executed in order in the configuration stage?

In my opinion - yes. They're always executed line by line.

HaoZeke commented 3 months ago

Thanks @mtsokol