search

HaoZeke / OpenBLAS

OpenBLAS is an optimized BLAS library based on GotoBLAS2 1.13 BSD version.
http://www.openblas.net
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

BLD: `ctest` port #8

Closed mtsokol closed 3 months ago

mtsokol commented 3 months ago

ctest port

HaoZeke commented 3 months ago

@mtsokol I updated these tests to ensure real failures are propagated correctly, similar changes are likely required in the other test PRs.

rgommers commented 3 months ago

Question: are changes to Fortran files upstreamable? In my experience it's going to be significantly easier to maintain/update if there's only changes specific to the Meson build that are parallel to the Makefile build, and no source-level changes.

HaoZeke commented 3 months ago

Question: are changes to Fortran files upstreamable? In my experience it's going to be significantly easier to maintain/update if there's only changes specific to the Meson build that are parallel to the Makefile build, and no source-level changes.

Yup, it basically switches from stop to call abort, which are equally well supported (in terms of language standards / compilation). The stop form basically reported no errors (i.e. return code was always 0), and didn't include a backtrace.