search

HaoboGu / rmk

Rust keyboard firmware library with layers, macros, real-time keymap editing, and wireless(BLE) support
https://haobogu.github.io/rmk/
Apache License 2.0
381 stars 28 forks source link

Permissive hold #74

Open davidqge opened 1 week ago

davidqge commented 1 week ago

Implemented the changes discussed here. Keyboard code changes tracking #71

Tap Hold works perfect now.

No longer need to slow typing.

davidqge commented 1 week ago

removed commit that change default feature. restored 10k/s scan added full sized keymap to reproduce stack protection fault

davidqge commented 1 week ago

Reverted the part of change in Matrix trait, so split code can build.

HaoboGu commented 1 week ago

This PR contains content of different topics, I suggest to split this to separate PRs, where each one focuses on only one thing.

btw force-push makes it harder to track what's changed between commits. If you want to make the commit history clean, splitting them to different PRs and squash merging is a better way imo.