search

Haojen / vimkey

⌨️ A browser extension, use the keyboard control browsers jumps, scrolling, switching tabs and more. support Safari, Chrome, andEdge
https://haojen.github.io/vimkey
131 stars 6 forks source link

Feature request: Open marked link in new tab #9

Closed exploitJ closed 2 years ago

exploitJ commented 2 years ago

shift + f to open selected element in new tab sounds reasonable.

Haojen commented 2 years ago

@exploitJ you mean active the opened new tab? not only in the background open it.

exploitJ commented 2 years ago

f key highlights visible links on the current page, then selected link performs open link

shift + f key feature does the same but performs open link on new tab instead.

Haojen commented 2 years ago

@exploitJ Emmm, This is how it works now, shift + f now behavior is opening the link on a new tab. If you shift + f not do this, please provide Vimkey version, OS, and link. we will find out what's happened

exploitJ commented 2 years ago

hmm, strange. System

It happens on every page.

edit: There's one thing I've discovered. f, <some-key> => open link shift + f => highlighting doesn't work.

f, shift + <some-key> => open link on new tab

Is this the intended behavior? I'm puzzled. 🤔

Haojen commented 2 years ago

@exploitJ yes, I got what you mean. you want when press shift + f and then choose a link and then open a link from a new tab, but this behavior can't recall if you pressed the wrong key (like if you don't want to open a new tab) so I think Vimkey now f -> shift + any key behavior is better. in this scene you can free choose an open link on a new tab or current tab

exploitJ commented 2 years ago

Oh I see. So that means it IS intended to be that way right? I'd better get used to it then 😁 Thanks for the help @Haojen

I'll close this issue.