search

Haoming02 / comfyui-diffusion-cg

Custom Nodes for ComfyUI that perform color grading based on the latent tensor value range
MIT License
85 stars 9 forks source link

SD Turbo scheduler support #1

Closed tastez closed 11 months ago

tastez commented 11 months ago

Hi thank you for the great work and article. Trying this out with SDXL Turbo and its working fine but without SD Turbo scheduler support its worse than expected.

sd turbo workflow is to use these nodes image

Haoming02 commented 11 months ago

Arrr... I knew Issue like this would happen. ComfyUI doesn't provide an easy way to hook the Callback, at least that I know of. So if I were to support it, I will need to copy the entire script just to change 1 line, for every new Sampler in the future...

TL;DR: Not planning to support it, until ComfyUI adds a way to hook callbacks.

Haoming02 commented 11 months ago

I've rewritten the entire extension It should work with the SamplerCustom now in the latest commit f1fd309~

tastez commented 11 months ago

nice change but doesnt affect a lot of common samplers that are all the rage now for turbo and lcm which is unfortunate since this is quite interesting and looks good

Haoming02 commented 11 months ago

Welp, that's truly unfortunate...