search

Haoming02 / sd-webui-resharpen

An Extension for Automatic1111 Webui that increases/decreases the details of images
MIT License
70 stars 5 forks source link

[Feature request] Additional parameters for adding noise #1

Closed miasik closed 1 month ago

miasik commented 5 months ago

First steps for initial rendering and latent hires fix are really sensitive for noise injection. Lasts steps could be left "sane" to make some "housecleaning" Could you please add parameters such as "start step" and "stop step" separately for initial and hires.fix?

Their behavior might be the next: if value is floating (0.5 as an example) it means that its real value is 0.5*NumberOfSteps if value is integer (2 as an example) it meaning is literal, so 2 steps

Haoming02 commented 1 month ago

(using the same logics as Vectorscope-CC)

miasik commented 1 month ago

(using the same logics as Vectorscope-CC)

Much, much better now! But it's not completed ;-) In my logic and experience I'd like to use different scaling for the first and hires steps — cos and sin respectively. Please make separate settings for the steps

Haoming02 commented 1 month ago

Now scaling is separated for normal txt2img and Hires. fix

miasik commented 1 month ago

Now scaling is separated for normal txt2img and Hires. fix

Super! Could you please elaborate on functions to scale? As we can see there: https://s3-us-west-2.amazonaws.com/courses-images/wp-content/uploads/sites/3252/2018/07/19143101/CNX_Precalc_Figure_06_01_005.jpg The functions have one period from 0 to 2pi. Do you use the full period or partially?

Haoming02 commented 1 month ago

You can refer to res_scaling.py

If my math didn't fail me, it only goes from 0° to 90°

ie. 1.0 to 0.0 for cos; 0.0 to 1.0 for sin

miasik commented 1 month ago

~If my math didn't fail me~, it only goes from 0° to 90° ie. 1.0 to 0.0 for cos; 0.0 to 1.0 for sin

Thanks. it's clear now! Need more time to check if I can work without start and stop steps limits