Haoming02 / sd-webui-tabs-extension

An Extension for Automatic1111 Webui that organizes Extensions into Tabs
MIT License
81 stars 2 forks source link

New bugs introduced in latest commit #20

Closed StylusEcho closed 3 weeks ago

StylusEcho commented 1 month ago

First of all thank you very much for implementing #16, from initial testing it seems to work exactly how I imagined.

However it seems like a couple of of bugs have been introduced.

  1. Under certain conditions, the textbox for tab_configs.csv doesn't seem to go away on Microsoft Edge, meanwhile on Firefox it disappears about the same time that Extra Networks are fully loaded. In these instances, clicking Save does not save any changes to the file either. There appears to be some correlation with the number of extensions installed, or it could be caused by a specific extension, still investigating.
  2. With Lobe Theme installed, above Tabs Extension these empty blocks appear: image
Haoming02 commented 1 month ago

The empty blocks mentioned in 2. is fixed~

As for the textbox mentioned in 1., increasing the Delay in Settings (so that it tries to save after Lobe theme does its thing) seems to work for me.

LindezaBlue commented 1 month ago

For me it messes with my defaults from being enabled to disabled. On top of that I get that setting box as well. Really annoying. image

LindezaBlue commented 1 month ago

The empty blocks mentioned in 2. is fixed~

As for the textbox mentioned in 1., increasing the Delay in Settings (so that it tries to save after Lobe theme does its thing) seems to work for me.

Where are these "settings" you speak of? I am not seeing anything in A1111 that allows the editing of the "Delay."

Haoming02 commented 1 month ago

Where are these "settings" you speak of?

vis223 commented 1 month ago

image

This appears on loading. Hitting 'save' has no effect apart from it all disappearing. Works fine in img2img. I pushed the delay to the highest setting but with no effect.

I'd want to investigate the differences between t2i and i2i. Can't help feeling there may just be one or two parameters difference that's throwing it out. Sadly, I don't code but thought I'd mention it in case it's a thing.

Thanks for the great extension. Having things break like this makes me appreciate how indispensable this is. It's very frustrating and I hope there's a simple fix soon.

Haoming02 commented 1 month ago

@vis223 Which UI are you using? And can you give me the list of all your Extensions?

vis223 commented 1 month ago

version: v1.10.0-RC-60-g8b3d98c5

SDXL Styles, ADetailer,Dynamic Prompts,Dynamic Thresholding (CFG Scale Fix), Diffusion CG, Memory Release, FABRIC, A Person Mask Generator, ControlNet, NegPiP, Attention Heatmap, Regional Prompter, CADS, Fooocus Expansion, Aspect Ratio and Resolution, Scramble Prompts [M9], Tweak Weights [M9], Detail Daemon, Refiner, Multi-Prompt Manager,

Does that give you the info you need?

ride5k commented 1 month ago

having same issue of persistent text block. extension list cut and pasted from box:

,txt,img tabs,left,right default,left,right GFPGAN,left,right CodeFormer,left,right ADetailer,left,right Tiled Diffusion,left,right DemoFusion,left,right Tiled VAE,left,right Face Editor,left,right Aspect Ratio Helper,left,right ControlNet,left,right Cutoff,left,right Kohya Hires.fix,left,right LoRA Block Weight : Active,left,right Dynamic Lora Weights,left,right Scripts,left,right A Person Mask Generator,left,right Segment Anything,left,right Upscale,left,right CADS,left,right Diffusion CG,left,right ReSharpen,left,right Detail Daemon,left,right

Haoming02 commented 1 month ago

Welp... I just cross checked the two lists, and installed all the shared ones, as well as checking out some of those that I've never heard of before, but I still don't get any issue...

Please update to the latest version, and see what error logs do you get.

Haoming02 commented 1 month ago

appears to be some correlation with the number of extensions installed

Probably not. Just tried with 25 Extensions that have accordion, and still no issues...

vis223 commented 1 month ago

Everything is up to date. I'm not exactly sure which log files you'd need. Is that the A1111 log file? Do I need to turn on debug mode or something?

What doesn't make sense to me is why it all works as it should on the image to image page but not on the text to image page. Surely if it was a conflict with a plug in then it wouldn't work on either?

LindezaBlue commented 1 month ago

Where are these "settings" you speak of?

Thanks for sharing where it was, I couldn't find it anywhere. Was racking my brain for days trying to find it.

Anyways, is there anything you can do to have the extension respect A1111 user defaults? When the extension is disabled/removed defaults work as intended and revert to what I had set for my defaults. But when I load the extension, all defaults switch to being disabled.

image

Adetailer, and TiledVAE usually are enabled as per my defaults, but with the extension messes with those defaults and disables them. I also can't set any new defaults with when the extension is installed. Not sure why this is the case, but defaults are only affected when I have the Tab Extension installed into A1111.


Updated to the latest commit as of 8/24/2024: image

adjusting the settings for the Delay has no effect. However it does seem to respect the UI Defaults now.. will continue to watch and see if it stays consistently respectful of the Defaults.

vis223 commented 4 weeks ago

image

Thanks a million, your last commit appears to have fixed the problem. Well done. I hope that's it for fixed everyone else having issues too. Your extension is totally essential and A1111 was a complete mess without it. All the best.

StylusEcho commented 4 weeks ago

Sorry, been away for a bit, but gave things a try with the latest commit. It looks like all issues I mentioned were resolved, so thanks a lot. This small cosmetic issue remains: image A blank space above. It is the first element inside the div "txt2img_script_container" and has the class "styler svelte-iyf88w". If it's too trivial I'll just block the element with my adblocker, it's not a big deal, but I thought i'd point it out.

Haoming02 commented 4 weeks ago

Added a new setting to hide the container~

LindezaBlue commented 4 weeks ago

seems to be fixed now, thank you!

StylusEcho commented 3 weeks ago

Everything is perfect now! Thanks a lot.