Hapag-Lloyd / terraform-aws-bastion-host-ssm

Terraform module to create an enterprise grade bastion host: High availability, SSM access only, encrypted disk and flexible resource naming.
Apache License 2.0
9 stars 4 forks source link

fix: terminate the instances instead of stopping them #287

Closed kayman-mk closed 5 months ago

kayman-mk commented 5 months ago

Description

Trigger the panic stop resulted in you are not allowed to stop spot instances. As we want to get rid of the whole instance, stopping is wrong. We need to terminate the instance, which works for spot instances too.

Verification

Manually verified in the HL environment.

Checklist

github-actions[bot] commented 5 months ago

Hey @kayman-mk! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under the Apache 2.0 license.

The following ChatOps commands are supported:

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

kayman-mk commented 5 months ago

/finish