search

Haplo064 / ChatBubbles

GNU General Public License v3.0
27 stars 31 forks source link

Rewrote player payload logic #19

Closed Asche00 closed 2 years ago

Asche00 commented 2 years ago

There were some edge cases that were still not determining the correct player (standard emotes that were targeted were ignoring the "You" part of the message when searching the cmessage payload for example.)

This should more consistently determine the sending player to place a chat bubble over.

The only case left is when a player from another server has the same name as the current player, but I am unsure how to resolve this. Dalamud doesn't seem to consistently append a home world in the sender parameter, but I believe characters with the same names will always be a bit odd right now due to the way GetActorId works.

It's a rare enough situation to potentially just not worry about handling it, but also something that could be looked into later.

Haplo064 commented 2 years ago

Added in via copy/paste instead of a merge because.