search

Haplo064 / ChatBubbles

GNU General Public License v3.0
27 stars 31 forks source link

Crash when too many people chat at the same time. #43

Closed SgtWiking closed 2 years ago

SgtWiking commented 2 years ago

Just had like 3 crashes since the chat bubble plugin update. Every time an S-rank gets killed and dozens of people say "ty for spawning" at the same time I (and my friend) crash. No crashing if we uninstall the plugin.

Never happened before the Endwalker update, so it might be a new problem? p.s. either way, thanks for the plugin, even with this problem I can't live without it <3

Haplo064 commented 2 years ago

Just pushed an update to fix some crashing. Ideally this will also be resolved, but I feel it might not be the same cause. Potentially somewhere checking for > 10 bubbles or somesuch. If it happens to anyone else please let me know. I don't hang out in places with a lot of chatter so it's hard to reproduce.

alsiniz commented 2 years ago

I too am crashing, and it usually happens around hunt marks, specifically S ranks where there are more people thanking the spawner after the kill.

Regarding reproduction I'd recommend going to a ShB or EW S rank that spawns on your data center. Faloop.app can notify you when someone shares one on your data center.

I tried combing the logs and this was all I could find leading up to the crash.

2022-05-04 13:35:18.050 +04:00 [INF] [ChatBubbles] [0] Old: Shout | New: Shout
2022-05-04 13:35:18.943 +04:00 [INF] [ChatBubbles] [1] Old: Shout | New: Shout
2022-05-04 13:35:18.943 +04:00 [INF] [ChatBubbles] [1] Old: Shout | New: Shout
2022-05-04 13:35:19.298 +04:00 [INF] [ChatBubbles] [0] Old: Shout | New: Shout
2022-05-04 13:35:19.447 +04:00 [INF] [ChatBubbles] [0] Old: Shout | New: Shout
2022-05-04 13:35:19.447 +04:00 [INF] [ChatBubbles] [0] Old: Shout | New: Shout
2022-05-04 13:35:19.657 +04:00 [INF] [ChatBubbles] [1] Old: Shout | New: Shout
2022-05-04 13:35:19.706 +04:00 [INF] [ChatBubbles] [3] Old: Shout | New: Shout
2022-05-04 13:35:20.013 +04:00 [INF] [ChatBubbles] [6] Old: Shout | New: Shout
2022-05-04 13:35:20.380 +04:00 [INF] [ChatBubbles] [1] Old: Shout | New: Shout
2022-05-04 13:35:20.806 +04:00 [INF] [ChatBubbles] [9] Old: Shout | New: Shout
2022-05-04 13:35:20.937 +04:00 [INF] [ChatBubbles] [9] Old: Shout | New: Shout

I crashed at 13:35 when everyone started thanking the spawner.

I didn't have this problem in 6.0

Haplo064 commented 2 years ago

Potentially fixed with: https://github.com/Haplo064/ChatBubbles/commit/63fed11422dc5804bb4a57c4e81b2a0a4327d98b#

Haplo064 commented 2 years ago

If I don't get a report of this for a month, I'll consider it fixed. (Once the update is pushed through to dalamud)

SgtWiking commented 2 years ago

I think it's good now. Did 4 S-rank hunts, two of each ended up with an SS-rank fight with hundreds of people, no crashes. It's a small sample size, but so far so good. Thanks for the quick reply/fix <3

Haplo064 commented 2 years ago

No further reports of this issue for several weeks, I'm going to close this out and tell myself I fixed it.